Fix typo in dynamic value syntax in Frame documentation#112
Merged
NoryiE merged 1 commit intoPyroxenium:masterfrom May 13, 2024
Merged
Fix typo in dynamic value syntax in Frame documentation#112NoryiE merged 1 commit intoPyroxenium:masterfrom
NoryiE merged 1 commit intoPyroxenium:masterfrom
Conversation
In Frame.md the dynamic values are surrounded by curly braces - "{parent.w-1}" instead of just "parent.w-1". This lead to the example code not running on any version of Basalt.
I simply removed the curly braces in this file, not sure if that broke something else or if there are other files that need the same treatment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Frame.md the dynamic values are surrounded by curly braces - "{parent.w-1}" instead of just "parent.w-1". This lead to the example code not running on any version of Basalt.
I simply removed the curly braces in this file, not sure if that broke something else or if there are other files that need the same treatment. This should resolve #109